[all-commits] [llvm/llvm-project] 06e08f: AArch64: Use reportFatalUsageError for unsupported...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 06e08f38e1ec57bf3cb5e08569b52eb6a3c3e166
      https://github.com/llvm/llvm-project/commit/06e08f38e1ec57bf3cb5e08569b52eb6a3c3e166
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    A llvm/test/CodeGen/AArch64/unsupported-cc-call.ll
    A llvm/test/CodeGen/AArch64/unsupported-cc-func.ll
    M llvm/test/MC/AArch64/coff-function-type-info.ll

  Log Message:
  -----------
  AArch64: Use reportFatalUsageError for unsupported calling conv (#144840)

This probably should emit a DiagnosticInfoUnsupported and use the
default calling convention instead, but then we would need to pass
in the context.

Also move where CCAssignFnForCall is called. It was unnecessarily
called for each argument, so the error wouldn't trigger for functions
with 0 arguments.

This only ensures the error occurs for functions defined with the
calling convention. The error is still missed for outgoing calls
with no arguments. The lowering logic here is convoluted, calling
CCAssignFnForCall for each argument and it does not mirror
LowerFormalArguments so I'm not sure what's going on here.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications