[all-commits] [llvm/llvm-project] a79c84: AArch64: Use reportFatalUsageError for unsupported...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Jun 19 22:28:14 PDT 2025


  Branch: refs/heads/users/arsenm/aarch64/reportFatalUsageError-unsupported-calling-convention
  Home:   https://github.com/llvm/llvm-project
  Commit: a79c84bf292b473b073a5b762858c7cbdef2cb8f
      https://github.com/llvm/llvm-project/commit/a79c84bf292b473b073a5b762858c7cbdef2cb8f
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    A llvm/test/CodeGen/AArch64/unsupported-cc-call.ll
    A llvm/test/CodeGen/AArch64/unsupported-cc-func.ll

  Log Message:
  -----------
  AArch64: Use reportFatalUsageError for unsupported calling conv

This probably should emit a DiagnosticInfoUnsupported and use the
default calling convention instead, but then we would need to pass
in the context.

Also move where CCAssignFnForCall is called. It was unnecessarily
called for each argument, so the error wouldn't trigger for functions
with 0 arguments.

This only ensures the error occurs for functions defined with the
calling convention. The error is still missed for outgoing calls
with no arguments. The lowering logic here is convoluted, calling
CCAssignFnForCall for each argument and it does not mirror
LowerFormalArguments so I'm not sure what's going on here.


  Commit: 3385d2bd04c3b5c8ad8209a08c4133efa2946931
      https://github.com/llvm/llvm-project/commit/3385d2bd04c3b5c8ad8209a08c4133efa2946931
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M llvm/test/MC/AArch64/coff-function-type-info.ll

  Log Message:
  -----------
  Fix an MC test using an arm calling convention


Compare: https://github.com/llvm/llvm-project/compare/aa6512edbcef...3385d2bd04c3

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list