[all-commits] [llvm/llvm-project] 1f34d6: [Remarks] Remove yaml-strtab format (#144527)

[Tobias Stadler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f34d68c4f086e7ea6ef9a529f9606476b38bbbb
      https://github.com/llvm/llvm-project/commit/1f34d68c4f086e7ea6ef9a529f9606476b38bbbb
  Author: Tobias Stadler <mail at stadler-tobias.de>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-opt-report.rst
    M llvm/docs/Remarks.rst
    M llvm/include/llvm/Remarks/RemarkFormat.h
    M llvm/include/llvm/Remarks/RemarkParser.h
    M llvm/include/llvm/Remarks/YAMLRemarkSerializer.h
    M llvm/lib/Remarks/BitstreamRemarkParser.cpp
    M llvm/lib/Remarks/BitstreamRemarkParser.h
    M llvm/lib/Remarks/RemarkFormat.cpp
    M llvm/lib/Remarks/RemarkLinker.cpp
    M llvm/lib/Remarks/RemarkParser.cpp
    M llvm/lib/Remarks/RemarkSerializer.cpp
    M llvm/lib/Remarks/RemarkStreamer.cpp
    M llvm/lib/Remarks/YAMLRemarkParser.cpp
    M llvm/lib/Remarks/YAMLRemarkParser.h
    M llvm/lib/Remarks/YAMLRemarkSerializer.cpp
    M llvm/test/CodeGen/X86/remarks-section.ll
    M llvm/unittests/Remarks/RemarksLinkingTest.cpp
    M llvm/unittests/Remarks/YAMLRemarksParsingTest.cpp
    M llvm/unittests/Remarks/YAMLRemarksSerializerTest.cpp

  Log Message:
  -----------
  [Remarks] Remove yaml-strtab format (#144527)

Background: The yaml-strtab format looks just like the yaml format,
except that the values in the key/value pairs of the remarks are
deduplicated and replaced by indices into a string table (see removed
test cases for examples). The motivation behind this format was to
reduce size of the remarks files. However, it was quickly superseded by
the bitstream format.

Therefore, remove the yaml-strtab format, as it doesn't have a good
usecase anymore:
  - It isn't particularly efficient
  - It isn't human-readable
  - It isn't straightforward to parse in external tools that can't use the
remarks library. We don't even support it in opt-viewer.

llvm-remarkutil is also missing options to parse/convert yaml-strtab, so
the chance that anyone is actually using this format is low.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications