[all-commits] [llvm/llvm-project] de24b8: [mlir][ArmSME] Remove `ConvertIllegalShapeCastOpsT...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/users/banach-space/sme/remove_ConvertIllegalShapeCastOpsToTransposes
  Home:   https://github.com/llvm/llvm-project
  Commit: de24b856bf974522258b28a258f610fecad605e0
      https://github.com/llvm/llvm-project/commit/de24b856bf974522258b28a258f610fecad605e0
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2025-06-17 (Tue, 17 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/ArmSME/vector-legalization.mlir
    M mlir/test/Dialect/Vector/canonicalize/vector-transpose.mlir

  Log Message:
  -----------
  [mlir][ArmSME] Remove `ConvertIllegalShapeCastOpsToTransposes`

As a follow-up to PR #135841 (see discussion for context), this patch
removes `ConvertIllegalShapeCastOpsToTransposes` from the SME legalization
pass and unblocks `ShapeCastOp::fold` for scalable vectors.

AFAIK, `ConvertIllegalShapeCastOpsToTransposes` was originally needed
because we were generating `vector.shape_cast` ops that couldn't be
lowered otherwise. To confirm it's no longer required, I tested this
patch locally using end-to-end tests.

Notably, this also removes a special case from `ShapeCastOp::fold`.


  Commit: d04d335a2ef48a433cb661665edd3e1ef47e7a04
      https://github.com/llvm/llvm-project/commit/d04d335a2ef48a433cb661665edd3e1ef47e7a04
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2025-06-18 (Wed, 18 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp
    M mlir/test/Dialect/ArmSME/vector-legalization.mlir

  Log Message:
  -----------
  fixup! [mlir][ArmSME] Remove `ConvertIllegalShapeCastOpsToTransposes`

Add LowerColumnTransferReadToLoops. Note, this is to address Ben's
comment here:
* https://github.com/llvm/llvm-project/pull/139706/files#r2088605443


Compare: https://github.com/llvm/llvm-project/compare/0bf798d0b392...d04d335a2ef4

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications