[all-commits] [llvm/llvm-project] a5a0d8: [libc++] Remove trailing newline from _LIBCPP_ASSE...

[Sam Clegg via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5a0d880736f5dc6a566374bc3b3ca0d86901510
      https://github.com/llvm/llvm-project/commit/a5a0d880736f5dc6a566374bc3b3ca0d86901510
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2025-06-17 (Tue, 17 Jun 2025)

  Changed paths:
    M libcxx/include/__assert
    M libcxx/src/verbose_abort.cpp
    M libcxx/test/support/check_assertion.h

  Log Message:
  -----------
  [libc++] Remove trailing newline from _LIBCPP_ASSERTION_HANDLER calls (#143573)

This newline was originally added in https://reviews.llvm.org/D142184
but I think updating `__libcpp_verbose_abort` to add newline instead is
more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`.

The `_LIBCPP_ASSERTION_HANDLER` calls through to either
`_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap`. From what
I can tell neither of these function expect a trailing newline (at least
none of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap`
that I can find include a trailing newline except `_LIBCPP_ASSERTION_HANDLER`).

I noticed this discrepancy when working on
https://github.com/emscripten-core/emscripten/pull/24543



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications