[all-commits] [llvm/llvm-project] 63b80d: [NFC][RootSignature] Use `llvm::EnumEntry` for ser...

Finn Plummer via All-commits all-commits at lists.llvm.org
Mon Jun 16 11:45:41 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63b80dd01dafc92104ee43e4f0f5296d644c25ec
      https://github.com/llvm/llvm-project/commit/63b80dd01dafc92104ee43e4f0f5296d644c25ec
  Author: Finn Plummer <finn.c.plum at gmail.com>
  Date:   2025-06-16 (Mon, 16 Jun 2025)

  Changed paths:
    M llvm/lib/Frontend/HLSL/HLSLRootSignatureUtils.cpp

  Log Message:
  -----------
  [NFC][RootSignature] Use `llvm::EnumEntry` for serialization of Root Signature Elements (#144106)

It has pointed out
[here](https://github.com/llvm/llvm-project/pull/143198#discussion_r2132877388)
that we may be able to use `llvm::EnumEntry` so that we can re-use the
printing logic across enumerations.

- Enables re-use of `printEnum` and `printFlags` methods via templates
- Allows easy definition of `getEnumName` function for enum-to-string
conversion, eliminating the need to use a string stream for constructing
the Name SmallString

- Also, does a small fix-up of the operands for descriptor table clause
to be consistent with other `Build*` methods

For reference, the
[test-cases](https://github.com/llvm/llvm-project/blob/main/llvm/unittests/Frontend/HLSLRootSignatureDumpTest.cpp)
that must not change expected output.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list