[all-commits] [llvm/llvm-project] 9e6229: [mlir][spirv] Fix FuncOpVectorUnroll to process pl...

[Darren Wihandi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e622986526a35f3f8bc60a7fc756b5c7bf825c0
      https://github.com/llvm/llvm-project/commit/9e622986526a35f3f8bc60a7fc756b5c7bf825c0
  Author: Darren Wihandi <65404740+fairywreath at users.noreply.github.com>
  Date:   2025-06-13 (Fri, 13 Jun 2025)

  Changed paths:
    M mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
    M mlir/test/Conversion/ConvertToSPIRV/func-signature-vector-unroll.mlir

  Log Message:
  -----------
  [mlir][spirv] Fix FuncOpVectorUnroll to process placeholder values in all blocks (#142339)

`FuncOpVectorUnroll` contains logic that replaces function arguments by
placeholders values. These replacements also involve changing all
instructions in the function that use the arguments to use these
placeholders. These placeholder values will later be changed back to use
the function arguments (either new or original if already legal).

The current implementation however only replaces back (the second
replacement, i.e. replacing the placeholder values to new/legal
arguments) the first block of instructions and not all of the blocks.
This may leave some instructions to use these placeholder values (which
for already legal arguments are just zeroattr values that will get
DCE'd) instead of the arguments, which is incorrect.

Closes #132158.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications