[all-commits] [llvm/llvm-project] 02aec8: [clangd] [Modules] Fix to correctly handle module ...

[Hans Wennborg via All-commits]

  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 02aec86e4d0d1740fd6ca5a01b3154938682910d
      https://github.com/llvm/llvm-project/commit/02aec86e4d0d1740fd6ca5a01b3154938682910d
  Author: fleeting-xx <bakerdt at gmail.com>
  Date:   2025-06-12 (Thu, 12 Jun 2025)

  Changed paths:
    M clang-tools-extra/clangd/ModulesBuilder.cpp
    M clang-tools-extra/clangd/ProjectModules.h
    M clang-tools-extra/clangd/ScanningProjectModules.cpp
    A clang-tools-extra/clangd/test/module_dependencies.test

  Log Message:
  -----------
  [clangd] [Modules] Fix to correctly handle module dependencies (#142828)

This is a re-application of llvm/llvm-project#142090 without the unit
test changes. A subsequent PR will follow that adds a unit test for
module dependencies.

- Fix dangling string references in the return value of
getAllRequiredModules()
- Change a couple of calls in getOrBuildModuleFile() to use the loop
variable instead of the ModuleName parameter.


  Commit: 199e02a3643318a16a0a7fdcc677ac55cf769fdb
      https://github.com/llvm/llvm-project/commit/199e02a3643318a16a0a7fdcc677ac55cf769fdb
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2025-06-12 (Thu, 12 Jun 2025)

  Changed paths:
    M clang-tools-extra/clangd/test/module_dependencies.test

  Log Message:
  -----------
  Disable clangd/test/module_dependencies.test on Windows

The test fails (sometimes); see discussion on https://github.com/llvm/llvm-project/pull/142828


Compare: https://github.com/llvm/llvm-project/compare/c4f257cb74b5...199e02a36433

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications