[all-commits] [llvm/llvm-project] 770622: Fix two instances of -Wparentheses warnings [NFC]

Mikael Holmén via All-commits all-commits at lists.llvm.org
Thu Jun 12 00:51:32 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77062244ed56be61aecda28d6fede3432545f741
      https://github.com/llvm/llvm-project/commit/77062244ed56be61aecda28d6fede3432545f741
  Author: Mikael Holmen <mikael.holmen at ericsson.com>
  Date:   2025-06-12 (Thu, 12 Jun 2025)

  Changed paths:
    M clang/lib/Sema/SemaOverload.cpp
    M llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp

  Log Message:
  -----------
  Fix two instances of -Wparentheses warnings [NFC]

Add parentheses around the assert conditions.

Without this gcc warned like
 ../lib/Target/AMDGPU/GCNSchedStrategy.cpp:2250: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
  2250 |          NewMI != RegionBounds.second && "cannot remove at region end");
and
 ../../clang/lib/Sema/SemaOverload.cpp:11326:39: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 11326 |          DeferredCandidatesCount == 0 &&
       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
 11327 |              "Unexpected deferred template candidates");
       |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list