[all-commits] [llvm/llvm-project] 2da24c: [libcxx] Provide locale conversions to tests throu...

[Louis Dionne via All-commits]

  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 2da24c36c7df73a686b2d990963faf3f738a510f
      https://github.com/llvm/llvm-project/commit/2da24c36c7df73a686b2d990963faf3f738a510f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2025-06-11 (Wed, 11 Jun 2025)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_fr_FR.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp
    M libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
    M libcxx/test/std/time/time.duration/time.duration.nonmember/ostream.pass.cpp
    M libcxx/test/support/locale_helpers.h
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx] Provide locale conversions to tests through lit substitution (#105651)

There are 2 problems today that this PR resolves:

libcxx tests assume the thousands separator for fr_FR locale is x00A0 on
Windows. This currently fails when run on newer versions of Windows (it
seems to have been updated to the new correct value of 0x202F around
windows 11. The exact windows version where it changed doesn't seem to
be documented anywhere). Depending the OS version, you need different
values.

There are several ifdefs to determine the environment/platform-specific
locale conversion values and it leads to maintenance as things change
over time.

This PR includes the following changes:

- Provide the environment's locale conversion values through a
  substitution. The test can opt in by placing the substitution value in a
  define flag.
- Remove the platform ifdefs (the swapping of values between Windows,
  Linux, Apple, AIX).

This is accomplished through a lit feature action that fetches the
environment's locale conversions (lconv) for members like
'thousands_sep' that we need to provide. This should ensure that we
don't lose the effectiveness of the test itself.

In addition, as a result of the above, this PR:

- Fixes a handful of locale tests which unexpectedly fail on newer
  Windows versions.
- Resolves 3 XFAIL FIX-MEs.

Originally submitted in https://github.com/llvm/llvm-project/pull/86649.

Co-authored-by: Rodrigo Salazar <4rodrigosalazar at gmail.com>
(cherry picked from commit f909b2229ac16ae3898d8b158bee85c384173dfa)


  Commit: b8e10ca59b6ad9d0c2828b418b5a17391ae6cda8
      https://github.com/llvm/llvm-project/commit/b8e10ca59b6ad9d0c2828b418b5a17391ae6cda8
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2025-06-11 (Wed, 11 Jun 2025)

  Changed paths:
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libc++] Fix check for _LIBCPP_HAS_NO_WIDE_CHARACTERS in features.py (#131675)

The patch that added the new locale Lit features was created before we
switched to a 0-1 macro for _LIBCPP_HAS_WIDE_CHARACTERS, leading to that
patch referring to the obsolete _LIBCPP_HAS_NO_WIDE_CHARACTERS macro
that is never defined nowadays.

(cherry picked from commit 297f6d9f6b215bd7f58cf500b979b94dedbba7bb)


Compare: https://github.com/llvm/llvm-project/compare/253e9321c8b6...b8e10ca59b6a

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications