[all-commits] [llvm/llvm-project] 7838fc: [Clang] [NFC] Move diagnostics emitting code from ...

[Sirraide via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7838fc0cd3fbe578d9554fdcd3198c2ba3616bcc
      https://github.com/llvm/llvm-project/commit/7838fc0cd3fbe578d9554fdcd3198c2ba3616bcc
  Author: Sirraide <aeternalmail at gmail.com>
  Date:   2025-06-11 (Wed, 11 Jun 2025)

  Changed paths:
    M clang/include/clang/Basic/Diagnostic.h
    M clang/include/clang/Basic/DiagnosticIDs.h
    M clang/lib/Basic/Diagnostic.cpp
    M clang/lib/Basic/DiagnosticIDs.cpp

  Log Message:
  -----------
  [Clang] [NFC] Move diagnostics emitting code from `DiagnosticIDs` into `DiagnosticsEngine` (#143517)

It makes more sense for this functionality to be all in one place rather
than split up across two files—at least it caused me a bit of a headache
to try and find all places where we were actually forwarding the
diagnostic to the `DiagnosticConsumer`. Moreover, moving these functions
into `DiagnosticsEngine` simplifies the code quite a bit since we access
members of `DiagnosticsEngine` more frequently than those of
`DiagnosticIDs`. There was also a duplicated code snippet that I’ve
moved out into a new function.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications