[all-commits] [llvm/llvm-project] 59e4d0: [flang][hlfir] ensure hlfir.declare result box att...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 59e4d0b34d6737c40a9d7cf4c5dd9dcaa651dd74
      https://github.com/llvm/llvm-project/commit/59e4d0b34d6737c40a9d7cf4c5dd9dcaa651dd74
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-06-10 (Tue, 10 Jun 2025)

  Changed paths:
    M flang/include/flang/Optimizer/Dialect/FIRType.h
    M flang/lib/Optimizer/Dialect/FIRType.cpp
    M flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp
    M flang/lib/Optimizer/HLFIR/Transforms/ConvertToFIR.cpp
    M flang/test/HLFIR/as_expr-codegen-polymorphic.fir
    M flang/test/HLFIR/associate-codegen.fir
    M flang/test/HLFIR/bufferize-poly-expr.fir
    A flang/test/HLFIR/declare-alloc-target.fir
    M flang/test/HLFIR/elemental-codegen.fir
    M flang/test/HLFIR/reshape-lowering.fir
    M flang/test/Lower/HLFIR/assumed-rank-entry.f90
    M flang/test/Lower/HLFIR/function-return-as-expr.f90
    M flang/test/Lower/HLFIR/poly_expr_for_nonpoly_dummy.f90
    M flang/test/Lower/HLFIR/polymorphic-expressions.f90
    M flang/test/Lower/HLFIR/select-type-selector.f90
    M flang/test/Lower/HLFIR/vector-subscript-as-value.f90
    M flang/test/Lower/volatile-allocatable.f90

  Log Message:
  -----------
  [flang][hlfir] ensure hlfir.declare result box attributes are consistent (#143137)

Prevent hlfir.declare output to be fir.box/class values with the
heap/pointer attribute to ensure the runtime descriptor attributes are
in line with the Fortran attributes for the entities being declared
(only fir.ref<box/class> can be ALLOCATABLE/POINTERS).

This fixes a bug where an associated entity inside a SELECT TYPE was being
unexpectedly reallocated inside assign runtime because the selector was allocatable
and this attribute was not properly removed when creating the descriptor
for the associated entity (that does not inherit the ALLOCATABLE/POINTER
attribute according to Fortran 2023 section 11.1.3.3).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications