[all-commits] [llvm/llvm-project] 6ec48b: [lldb] Use 1 based row and column for statusline (...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ec48b449fb60a766d4faf185613f1b4a8638bfa
      https://github.com/llvm/llvm-project/commit/6ec48b449fb60a766d4faf185613f1b4a8638bfa
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-06-10 (Tue, 10 Jun 2025)

  Changed paths:
    M lldb/source/Core/Statusline.cpp
    M lldb/test/API/functionalities/statusline/TestStatusline.py

  Log Message:
  -----------
  [lldb] Use 1 based row and column for statusline (#143385)

I can't find a proper source for this but many materials say that ANSI
rows and columns start at 1 not 0.

https://www2.math.upenn.edu/~kazdan/210/computer/ansi.html is as good as
I can get:
```
<row> is a number from 1 through 25 that specifies the row to which the cursor is to be moved.
<col> is a number from 1 through 80 that specifies the column to which the cursor is to be moved.
```

0 does work in Windows terminal and Linux terminals, but we might as
well be correct and it's one less thing to reason about when auditing
this code.

>From what I read, some terminals correct 0 back to 1 and some treat 0 as
a missing argument, which also defaults to 1.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications