[all-commits] [llvm/llvm-project] 9f82ac: Remove GlobalObject::getAlign/setAlignment (#143188)

Eli Friedman via All-commits all-commits at lists.llvm.org
Mon Jun 9 13:51:24 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f82ac5738fced23716ac6f9c5744f99d6b6ba92
      https://github.com/llvm/llvm-project/commit/9f82ac5738fced23716ac6f9c5744f99d6b6ba92
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2025-06-09 (Mon, 09 Jun 2025)

  Changed paths:
    M llvm/include/llvm/IR/Function.h
    M llvm/include/llvm/IR/GlobalObject.h
    M llvm/include/llvm/IR/GlobalVariable.h
    M llvm/include/llvm/SandboxIR/Constant.h
    M llvm/include/llvm/SandboxIR/Function.h
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/IR/Core.cpp
    M llvm/lib/IR/IRBuilder.cpp
    M llvm/lib/IR/Value.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/LTO/LTOModule.cpp
    M llvm/lib/SandboxIR/Constant.cpp
    M llvm/lib/SandboxIR/Function.cpp
    M llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
    M llvm/lib/Target/SystemZ/SystemZSubtarget.cpp
    M llvm/lib/Transforms/Utils/Local.cpp
    M llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp
    M llvm/unittests/SandboxIR/SandboxIRTest.cpp

  Log Message:
  -----------
  Remove GlobalObject::getAlign/setAlignment (#143188)

Currently, GlobalObject has an "alignment" property... but it's
basically nonsense: alignment doesn't mean the same thing for variables
and functions, and it's completely meaningless for ifuncs.

This "removes" (actually marking protected) the methods from
GlobalObject, adds the relevant methods to Function and GlobalVariable,
and adjusts the code appropriately.

This should make future alignment-related cleanups easier.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list