[all-commits] [llvm/llvm-project] 347186: Avoid Assertion Failure Using -fcs-profile-generat...

[Nuri Amari via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 347186b25969adcb8621c0b21226f10e7a193f8d
      https://github.com/llvm/llvm-project/commit/347186b25969adcb8621c0b21226f10e7a193f8d
  Author: Nuri Amari <nuri.amari99 at gmail.com>
  Date:   2025-06-06 (Fri, 06 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp
    A clang/test/CodeGen/distributed-thin-lto/backend-skip.ll
    A clang/test/CodeGen/distributed-thin-lto/basic.ll
    A clang/test/CodeGen/distributed-thin-lto/cfi-devirt.ll
    A clang/test/CodeGen/distributed-thin-lto/cfi.ll
    A clang/test/CodeGen/distributed-thin-lto/cs-irpgo.c
    A clang/test/CodeGen/distributed-thin-lto/newpm.ll
    A clang/test/CodeGen/distributed-thin-lto/objc-contract-pass.ll
    A clang/test/CodeGen/distributed-thin-lto/supports-hot-cold-new.ll
    R clang/test/CodeGen/thinlto-distributed-backend-skip.ll
    R clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll
    R clang/test/CodeGen/thinlto-distributed-cfi.ll
    R clang/test/CodeGen/thinlto-distributed-newpm.ll
    R clang/test/CodeGen/thinlto-distributed-objc-contract-pass.ll
    R clang/test/CodeGen/thinlto-distributed-supports-hot-cold-new.ll
    R clang/test/CodeGen/thinlto-distributed.ll

  Log Message:
  -----------
  Avoid Assertion Failure Using -fcs-profile-generate with distributed thin-lto (#129736)

When using `-fcs-generate-profile` with distributed thin-lto in the same
fashion we do for local thin-lto, we hit the following assertion:


https://github.com/llvm/llvm-project/blob/6041c745f32e8fd60ed24e29e7d919d8d1c87ca6/llvm/lib/Support/PGOOptions.cpp#L36

Using local thin-lto with LLD for MachO, we set the missing path
automatically to a default value: https://reviews.llvm.org/D151589. In
this fix we add the same behavior.

---------

Co-authored-by: Nuri Amari <nuriamari at fb.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications