[all-commits] [llvm/llvm-project] 752adc: [clang][Darwin] Simplify deployment version assign...

[Cyndy Ishida via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 752adc36ef5ae4d0924675f4e5a43c3ec380b35b
      https://github.com/llvm/llvm-project/commit/752adc36ef5ae4d0924675f4e5a43c3ec380b35b
  Author: Cyndy Ishida <cyndy_ishida at apple.com>
  Date:   2025-06-05 (Thu, 05 Jun 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticDriverKinds.td
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/Driver/darwin-debug-flags.c
    M clang/test/Driver/darwin-version.c

  Log Message:
  -----------
  [clang][Darwin] Simplify deployment version assignment in the Driver (#142013)

To be able to handle all of the ways the platform & deployment version
can be represented in command line flags, the Darwin toolchain holds a
type `DarwinPlatform` to help represent them. This patch simplifies the
logic by:
* reducing the amount of work done between string & version tuples
conversions
* renaming variables to reduce confusion about what target triple
information is being manipulated.
* allowing implicit transformation of macOS10.16 -> 11, there are other
places in the compiler where this happens, and it was a bit confusing
that the driver didn't do that for the cc1 call.

This is not a major refactor, but more simple & common tweaks across the
file, in hopes to make it more readable.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications