[all-commits] [llvm/llvm-project] 3096f8: [lldb] Don't create instance of `SymbolFileDWARFDe...

[royitaqi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3096f8768676bd64123270cc59b7cc904a72d875
      https://github.com/llvm/llvm-project/commit/3096f8768676bd64123270cc59b7cc904a72d875
  Author: royitaqi <royitaqi at users.noreply.github.com>
  Date:   2025-06-05 (Thu, 05 Jun 2025)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
    M lldb/unittests/SymbolFile/DWARF/CMakeLists.txt
    A lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFDebugMapTests.cpp

  Log Message:
  -----------
  [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (#139170)

# Change

`SymbolFileDWARFDebugMap::CreateInstance()` will return `nullptr` if the
file is not a Mach-O.


# Benefit

This may improve **Linux** debugger launch time by skipping the creation
of `SymbolFileDWARFDebugMap` during the [`SymbolFile::FindPlugin()`
call](https://fburl.com/hi1w8dil), which loops through a list of
`SymbolFile` plugins and tries to find the one that provides the best
abilities. If the `SymbolFileDWARFDebugMap` is created during this loop,
it will load the symbol table of the file in question and loop through
all the compile units in the debug map (the OSO entries) to calculate
the abilities.


# Tests

See PR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications