[all-commits] [llvm/llvm-project] f32f04: [llvm] Use ABI instead of preferred alignment for ...

[PiJoules via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f32f048719455b4813ff7115e4f3a6cdc65efff0
      https://github.com/llvm/llvm-project/commit/f32f048719455b4813ff7115e4f3a6cdc65efff0
  Author: PiJoules <6019989+PiJoules at users.noreply.github.com>
  Date:   2025-06-04 (Wed, 04 Jun 2025)

  Changed paths:
    M llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
    A llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-ignore-preferred-alignment.ll
    M llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-small-alignment-32.ll
    M llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-small-alignment-64.ll

  Log Message:
  -----------
  [llvm] Use ABI instead of preferred alignment for const prop checks (#142500)

We'd hit an assertion checking proper alignment for an i8 when building
chromium because we used the prefered alignment (which is 4 bytes)
instead of the ABI alignment (which is 1 byte). The ABI alignment should
be used because that's the actual alignment needed to load a constant
from the vtable.

This also updates the two `virtual-const-prop-small-alignment-*` to
explicitly give ABI alignments for i64s.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications