[all-commits] [llvm/llvm-project] f4e222: [clang-tidy] NFCI: remove non-functional matcher f...

Matheus Izvekov via All-commits all-commits at lists.llvm.org
Tue Jun 3 11:53:58 PDT 2025


  Branch: refs/heads/users/mizvekov/SizeofExpressionCheck-remove-nonfunctional-matcher
  Home:   https://github.com/llvm/llvm-project
  Commit: f4e222ad64ce5edeadbaed5adceedff40043dcd0
      https://github.com/llvm/llvm-project/commit/f4e222ad64ce5edeadbaed5adceedff40043dcd0
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp

  Log Message:
  -----------
  [clang-tidy] NFCI: remove non-functional matcher from SizeofExpressionCheck

This matcher would never match anything, because all record types as-written
would be wrappen in an ElaboratedType.

Just fixing that leads to a matcher which has too many false positives
to be useful.

The warning message itself is not great either, it has a hard-coded type
name.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list