[all-commits] [llvm/llvm-project] 9ec5af: [NFC][RootSignature] Move RootSignature util funct...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9ec5afea773783b73b575d397dfdc8fba1fd596b
      https://github.com/llvm/llvm-project/commit/9ec5afea773783b73b575d397dfdc8fba1fd596b
  Author: Finn Plummer <finn.c.plum at gmail.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/AST/TextNodeDumper.cpp
    M clang/lib/CodeGen/CGHLSLRuntime.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
    A llvm/include/llvm/Frontend/HLSL/HLSLRootSignatureUtils.h
    M llvm/lib/Frontend/HLSL/CMakeLists.txt
    R llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp
    A llvm/lib/Frontend/HLSL/HLSLRootSignatureUtils.cpp
    M llvm/unittests/Frontend/HLSLRootSignatureDumpTest.cpp

  Log Message:
  -----------
  [NFC][RootSignature] Move RootSignature util functions (#142491)

`HLSLRootSignature.h` was originally created to hold the struct
definitions of an `llvm::hlsl::rootsig::RootElement` and some helper
functions for it.

However, there many users of the structs that don't require any of the
helper methods. This requires us to link the `FrontendHLSL` library,
where we otherwise wouldn't need to.

For instance:
- This [revert](https://github.com/llvm/llvm-project/pull/142005) was
required as it requires linking to the unrequired `FrontendHLSL` library
- As part of the change required here:
https://github.com/llvm/llvm-project/issues/126557. We will want to add
an `HLSLRootSignatureVersion` enum. Ideally this could live with the
root signature struct defs, but we don't want to link the helper objects
into `clang/Basic/TargetOptions.h`

This change allows the struct definitions to be kept in a single header
file and to then have the `FrontendHLSL` library only be linked when
required.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications