[all-commits] [llvm/llvm-project] b78bc3: [Offload] Don't check in generated files (#141982)

[Callum Fare via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b78bc35d1629e9a07e0c6c677c5a1f477934b659
      https://github.com/llvm/llvm-project/commit/b78bc35d1629e9a07e0c6c677c5a1f477934b659
  Author: Callum Fare <callum at codeplay.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M offload/CMakeLists.txt
    R offload/include/Shared/OffloadErrcodes.inc
    R offload/include/Shared/OffloadError.h
    M offload/liboffload/API/CMakeLists.txt
    M offload/liboffload/CMakeLists.txt
    R offload/liboffload/include/generated/OffloadAPI.h
    R offload/liboffload/include/generated/OffloadEntryPoints.inc
    R offload/liboffload/include/generated/OffloadFuncs.inc
    R offload/liboffload/include/generated/OffloadImplFuncDecls.inc
    R offload/liboffload/include/generated/OffloadPrint.hpp
    M offload/liboffload/src/Helpers.hpp
    M offload/plugins-nextgen/CMakeLists.txt
    M offload/plugins-nextgen/common/CMakeLists.txt
    A offload/plugins-nextgen/common/include/OffloadError.h
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/common/src/OffloadError.cpp

  Log Message:
  -----------
  [Offload] Don't check in generated files (#141982)

Previously we decided to check in files that we generate with tablegen.
The justification at the time was that it helped reviewers unfamiliar
with `offload-tblgen` see the actual changes to the headers in PRs.
After trying it for a while, it's ended up causing some headaches and is
also not how tablegen is used elsewhere in LLVM.

This changes our use of tablegen to be more conventional. Where
possible, files are still clang-formatted, but this is no longer a hard
requirement. Because `OffloadErrcodes.inc` is shared with libomptarget
it now gets generated in a more appropriate place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications