[all-commits] [llvm/llvm-project] a88373: [KeyInstr][Clang] Ret atom

Tue Jun 3 07:40:01 PDT 2025

  Branch: refs/heads/users/OCHyams/ki-clang-ret
  Home:   https://github.com/llvm/llvm-project
  Commit: a8837383c3289ab1c1e93b5fa00371241fa55fb4
      https://github.com/llvm/llvm-project/commit/a8837383c3289ab1c1e93b5fa00371241fa55fb4
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp
    M clang/lib/CodeGen/CGStmt.cpp
    M clang/lib/CodeGen/CodeGenFunction.cpp
    A clang/test/DebugInfo/KeyInstructions/return-va-arg.c
    A clang/test/DebugInfo/KeyInstructions/return.c

  Log Message:
  -----------
  [KeyInstr][Clang] Ret atom

This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.

The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.

The Clang-side work is demoed here:
https://github.com/llvm/llvm-project/pull/130943

  Commit: c24cdd73bbae6f57f6f0ff5fcdec52e0bfc6853d
      https://github.com/llvm/llvm-project/commit/c24cdd73bbae6f57f6f0ff5fcdec52e0bfc6853d
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/test/DebugInfo/KeyInstructions/agg.c
    M clang/test/DebugInfo/KeyInstructions/assign-scalar.c
    M clang/test/DebugInfo/KeyInstructions/bitfield.cpp
    M clang/test/DebugInfo/KeyInstructions/builtin.c
    M clang/test/DebugInfo/KeyInstructions/complex.c
    M clang/test/DebugInfo/KeyInstructions/do.c
    M clang/test/DebugInfo/KeyInstructions/if.c
    M clang/test/DebugInfo/KeyInstructions/init-agg.c
    M clang/test/DebugInfo/KeyInstructions/init-member.cpp
    M clang/test/DebugInfo/KeyInstructions/init-scalar.c
    M clang/test/DebugInfo/KeyInstructions/init-static.cpp
    M clang/test/DebugInfo/KeyInstructions/try-catch.cpp
    M clang/test/DebugInfo/KeyInstructions/while.c

  Log Message:
  -----------
  [KeyInstr][Clang] Update tests with ret atoms

  Commit: 8dceef18b861499ffbcc5873ed750d0142254ba7
      https://github.com/llvm/llvm-project/commit/8dceef18b861499ffbcc5873ed750d0142254ba7
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp
    M clang/lib/CodeGen/CodeGenFunction.cpp
    M clang/lib/CodeGen/CodeGenFunction.h
    M clang/test/DebugInfo/KeyInstructions/agg.c
    M clang/test/DebugInfo/KeyInstructions/assign-scalar.c
    A clang/test/DebugInfo/KeyInstructions/assign.c
    M clang/test/DebugInfo/KeyInstructions/bitfield.cpp
    M clang/test/DebugInfo/KeyInstructions/builtin.c
    M clang/test/DebugInfo/KeyInstructions/complex.c
    M clang/test/DebugInfo/KeyInstructions/do.c
    M clang/test/DebugInfo/KeyInstructions/if.c
    M clang/test/DebugInfo/KeyInstructions/init-agg.c
    A clang/test/DebugInfo/KeyInstructions/init-agg.cpp
    M clang/test/DebugInfo/KeyInstructions/init-member.cpp
    M clang/test/DebugInfo/KeyInstructions/init-scalar.c
    M clang/test/DebugInfo/KeyInstructions/init-static.cpp
    M clang/test/DebugInfo/KeyInstructions/try-catch.cpp
    M clang/test/DebugInfo/KeyInstructions/while.c

  Log Message:
  -----------
  fix rebase fallout - use new addInstToSpecificSourceAtom function, and fixup some tests

  Commit: 155ef268196e6060dd2a539b8d7ded8ea3f00fde
      https://github.com/llvm/llvm-project/commit/155ef268196e6060dd2a539b8d7ded8ea3f00fde
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/test/DebugInfo/KeyInstructions/return-va-arg.c
    M clang/test/DebugInfo/KeyInstructions/return.c

  Log Message:
  -----------
  cc1

  Commit: 33f85854717e985fc47ea37a431f050ed2839c49
      https://github.com/llvm/llvm-project/commit/33f85854717e985fc47ea37a431f050ed2839c49
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CodeGenFunction.cpp

  Log Message:
  -----------
  rm rebase weirdness

  Commit: 855854e5664df71c8056ddfe820465f35aba5750
      https://github.com/llvm/llvm-project/commit/855854e5664df71c8056ddfe820465f35aba5750
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CodeGenFunction.cpp

  Log Message:
  -----------
  rm cruft

  Commit: 2972ae501a88cfba93ab9e7f8af0f26d6216f090
      https://github.com/llvm/llvm-project/commit/2972ae501a88cfba93ab9e7f8af0f26d6216f090
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/test/DebugInfo/KeyInstructions/assign-scalar.c
    M clang/test/DebugInfo/KeyInstructions/builtin.c
    M clang/test/DebugInfo/KeyInstructions/complex.c
    M clang/test/DebugInfo/KeyInstructions/multi-func.c
    M clang/test/DebugInfo/KeyInstructions/return-va-arg.c
    M clang/test/DebugInfo/KeyInstructions/return.c

  Log Message:
  -----------
  fix tests

  Commit: 1fd0c86a9749ca38b0f1cb8dacfe6a4aac65d83c
      https://github.com/llvm/llvm-project/commit/1fd0c86a9749ca38b0f1cb8dacfe6a4aac65d83c
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    R clang/test/DebugInfo/KeyInstructions/assign.c
    R clang/test/DebugInfo/KeyInstructions/init-agg.cpp
    R clang/test/DebugInfo/KeyInstructions/init-member.cpp

  Log Message:
  -----------
  rm tests introduced in flaky rebase

  Commit: f767dac37bad002d504a53b5f6c1de3f3bf0f0a1
      https://github.com/llvm/llvm-project/commit/f767dac37bad002d504a53b5f6c1de3f3bf0f0a1
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/lib/CodeGen/CGStmt.cpp

  Log Message:
  -----------
  rm comment - don't need to mark sanitizer stores as key

  Commit: 3662b0ec84a41aaf5efac54f5aee13d59f3527af
      https://github.com/llvm/llvm-project/commit/3662b0ec84a41aaf5efac54f5aee13d59f3527af
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    A clang/test/DebugInfo/KeyInstructions/init-member.cpp

  Log Message:
  -----------
  re-add accidentally removed test

  Commit: 3dd3e9c0ce18953267686ba7f3c387eb77351581
      https://github.com/llvm/llvm-project/commit/3dd3e9c0ce18953267686ba7f3c387eb77351581
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/test/DebugInfo/KeyInstructions/agg.c
    M clang/test/DebugInfo/KeyInstructions/assign-scalar.c
    M clang/test/DebugInfo/KeyInstructions/bitfield.cpp
    M clang/test/DebugInfo/KeyInstructions/builtin.c
    M clang/test/DebugInfo/KeyInstructions/complex.c
    M clang/test/DebugInfo/KeyInstructions/do.c
    M clang/test/DebugInfo/KeyInstructions/if.c
    M clang/test/DebugInfo/KeyInstructions/init-agg.c
    M clang/test/DebugInfo/KeyInstructions/init-member.cpp
    M clang/test/DebugInfo/KeyInstructions/init-scalar.c
    M clang/test/DebugInfo/KeyInstructions/init-static.cpp
    M clang/test/DebugInfo/KeyInstructions/try-catch.cpp
    M clang/test/DebugInfo/KeyInstructions/while.c

  Log Message:
  -----------
  specify expected ret atomGroup

  Commit: 689c1b14be46cd533163d78f985ed652cedc318e
      https://github.com/llvm/llvm-project/commit/689c1b14be46cd533163d78f985ed652cedc318e
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M clang/test/DebugInfo/KeyInstructions/cast.c
    M clang/test/DebugInfo/KeyInstructions/coerced-packed.c
    M clang/test/DebugInfo/KeyInstructions/coerced-ptr.c
    M clang/test/DebugInfo/KeyInstructions/coerced-through-memory.c
    M clang/test/DebugInfo/KeyInstructions/coerced.c
    M clang/test/DebugInfo/KeyInstructions/for.c
    M clang/test/DebugInfo/KeyInstructions/new.cpp
    M clang/test/DebugInfo/KeyInstructions/switch.c

  Log Message:
  -----------
  update new tests after rebase too

Compare: https://github.com/llvm/llvm-project/compare/37c869ab01e3...689c1b14be46

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications