[all-commits] [llvm/llvm-project] bb75f6: [IRMover] Don't consider opaque types isomorphic t...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb75f655b08d0758bd91650ec2fe1004673da462
      https://github.com/llvm/llvm-project/commit/bb75f655b08d0758bd91650ec2fe1004673da462
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M llvm/lib/Linker/IRMover.cpp
    M llvm/test/Linker/opaque.ll
    M llvm/test/Linker/pr22807.ll
    M llvm/test/Linker/type-unique-dst-types.ll

  Log Message:
  -----------
  [IRMover] Don't consider opaque types isomorphic to other types (#138241)

The type mapping in IRMover currently has a decent amount of complexity
related to establishing isomorphism between opaque struct types and
non-opaque struct types. I believe that this is both largely useless at
this point (after some recent clarifications, essentially the only place
where opaque types can still appear are external gobals) and has never
been entirely correct in the first place (because it does this in part
purely based on name rather than use, which means that we effectively
end up assigning semantics to the type name, which is illegal).

As such, I'd like to remove this functionality entirely.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications