[all-commits] [llvm/llvm-project] b4ded9: [MLIR] Make SymbolTableCollection methods virtual ...

Michele Scuttari via All-commits all-commits at lists.llvm.org
Tue Jun 3 01:53:38 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4ded99a4a34d736537a98be6a1873944b8ffe82
      https://github.com/llvm/llvm-project/commit/b4ded99a4a34d736537a98be6a1873944b8ffe82
  Author: Michele Scuttari <michele.scuttari at outlook.com>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M mlir/include/mlir/IR/SymbolTable.h

  Log Message:
  -----------
  [MLIR] Make SymbolTableCollection methods virtual (#141760)

The `LockedSymbolTable` class not only encapsulate a `SymbolTableCollection`, but also extends it. However, the methods of `SymbolTableCollection` are not marked as `virtual`, and therefore methods receiving a `SymbolTableCollection` would always call the base methods even if the object was a subclass. The proposed changes consist in marking the base methods as `virtual`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list