[all-commits] [llvm/llvm-project] 6206d7: [X86] combineConstantPoolLoads - correctly merge c...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Tue Jun 3 01:08:17 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6206d7d3e1979e7f3e66538614f9f44413a16905
      https://github.com/llvm/llvm-project/commit/6206d7d3e1979e7f3e66538614f9f44413a16905
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2025-06-03 (Tue, 03 Jun 2025)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] combineConstantPoolLoads - correctly merge constant pool loads by pointer and chain (#139575)

We were merging with a larger constant pool load if it didn't have any
chain dependencies (and implicitly assuming all uses were on the vector
value), instead we should flip this, explicitly check for uses of the
vector value and merge the memory chain dependencies with
makeEquivalentMemoryOrdering.

As these are constant pool loads we shouldn't expect any changes here,
but we should be consistent with how we merge/reuse loads - an upcoming
patch for other loads will do the same as we will see changes there.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list