[all-commits] [llvm/llvm-project] 34bb64: [llvm] annotate interfaces in AsmParser, BinaryFor...

[Andrew Rogers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34bb6426600f8d10f36f47d6f3eb243c4ced66eb
      https://github.com/llvm/llvm-project/commit/34bb6426600f8d10f36f47d6f3eb243c4ced66eb
  Author: Andrew Rogers <andrurogerz at gmail.com>
  Date:   2025-06-02 (Mon, 02 Jun 2025)

  Changed paths:
    M llvm/include/llvm/AsmParser/Parser.h
    M llvm/include/llvm/BinaryFormat/AMDGPUMetadataVerifier.h
    M llvm/include/llvm/BinaryFormat/COFF.h
    M llvm/include/llvm/BinaryFormat/DXContainer.h
    M llvm/include/llvm/BinaryFormat/Dwarf.h
    M llvm/include/llvm/BinaryFormat/ELF.h
    M llvm/include/llvm/BinaryFormat/MachO.h
    M llvm/include/llvm/BinaryFormat/Magic.h
    M llvm/include/llvm/BinaryFormat/MsgPackDocument.h
    M llvm/include/llvm/BinaryFormat/MsgPackReader.h
    M llvm/include/llvm/BinaryFormat/MsgPackWriter.h
    M llvm/include/llvm/BinaryFormat/Wasm.h
    M llvm/include/llvm/BinaryFormat/XCOFF.h
    M llvm/include/llvm/Bitcode/BitcodeAnalyzer.h
    M llvm/include/llvm/Bitcode/BitcodeReader.h
    M llvm/include/llvm/Bitcode/BitcodeWriter.h
    M llvm/include/llvm/Bitcode/BitcodeWriterPass.h
    M llvm/include/llvm/Bitstream/BitstreamReader.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

  Log Message:
  -----------
  [llvm] annotate interfaces in AsmParser, BinaryFormat, Bitcode, and Bitstream libraries for DLL export (#141794)

## Purpose

This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/AsmParser`,
`llvm/BinaryFormat`, `llvm/Bitcode` and `llvm/Bitstream libraries. These
annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.

## Background

This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).

The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.

The following manual adjustments were also applied after running IDS on
Linux:
- Add `LLVM_ABI_FRIEND` to friend member functions declared with
`LLVM_ABI`
- Add `LLVM_ABI` symbols that require export but are not declared in
headers

## Validation

Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:

- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications