[all-commits] [llvm/llvm-project] 5b8031: [Offload][AMDGPU] Correctly handle variable implic...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Jun 2 07:35:38 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b8031a7f7e278af5ab9418a3dfa2cad66310278
      https://github.com/llvm/llvm-project/commit/5b8031a7f7e278af5ab9418a3dfa2cad66310278
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2025-06-02 (Mon, 02 Jun 2025)

  Changed paths:
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h

  Log Message:
  -----------
  [Offload][AMDGPU] Correctly handle variable implicit argument sizes (#142199)

Summary:
The size of the implicit argument struct can vary depending on
optimizations, it is not always the size as listed by the full struct.
Additionally, the implicit arguments are always aligned on a pointer
boundary. This patch updates the handling to use the correctly aligned
offset and only initialize the members if they are contained in the
reported size.

Additionally, we modify the `alloc` and `free` routines to allow
`alloc(0)` and `free(nullptr)` as these are mandated by the C standard
and allow us to easily handle cases where the user calls a kernel with
no arguments.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list