[all-commits] [llvm/llvm-project] e49738: [mlir][lsp] Enable registering dialects based on U...

[Jacques Pienaar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e49738b3acf410f16b51753d71c88a29dd8fcf77
      https://github.com/llvm/llvm-project/commit/e49738b3acf410f16b51753d71c88a29dd8fcf77
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2025-06-01 (Sun, 01 Jun 2025)

  Changed paths:
    A mlir/include/mlir/Tools/mlir-lsp-server/MlirLspRegistryFunction.h
    M mlir/include/mlir/Tools/mlir-lsp-server/MlirLspServerMain.h
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.cpp
    M mlir/lib/Tools/mlir-lsp-server/MLIRServer.h
    M mlir/lib/Tools/mlir-lsp-server/MlirLspServerMain.cpp
    A mlir/test/mlir-lsp-server/uri-based-registration.test
    M mlir/tools/mlir-lsp-server/mlir-lsp-server.cpp
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][lsp] Enable registering dialects based on URI. (#141331)

Previously the dialects registered were fixed per LSP binary. This works
as long as all the dialects of interest from the different projects
across which one uses the LSP, are disjoint. This expands this to
support cases where there are dialects that overlap in dialect name but
usage of these are separate wrt projects. The alternative is multiple
binaries and switching LSP used in editor per project (there is some
extra complexity in hosted instances).

This handles a simple (I believe common case) where one can determine
based on path and have single binary - the cost of dynamically doing so
based on path would be either keeping different registries to return or
repopulating dialect & extension maps.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications