[all-commits] [llvm/llvm-project] 4425b5: X86AsmBackend: Remove some computeFragmentSize calls

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4425b513f3f6d1abb82635309d4eafd2aac6ded5
      https://github.com/llvm/llvm-project/commit/4425b513f3f6d1abb82635309d4eafd2aac6ded5
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-06-01 (Sun, 01 Jun 2025)

  Changed paths:
    M llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp

  Log Message:
  -----------
  X86AsmBackend: Remove some computeFragmentSize calls

The function was brittle as it performed only one iteration, which might
not converge. The reverted be5a845e4c29aadb513ae6e5e2879dccf37efdbb
mentioned that !NDEBUG and NDEBUG builds evaluated fragment offsets at
different times.

    * X86AsmBackend::finishLayout performed only one iteration, which might
      not converge. In addition, the removed `#ifndef NDEBUG` code (disabled
      by default) in X86AsmBackend::finishLayout was problematic, as !NDEBUG
      and NDEBUG builds evaluated fragment offsets at different times before
      this patch.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications