[all-commits] [llvm/llvm-project] f669b9: [lldb][test] Test all libcxxabi demangler test-cas...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f669b9c3eca9438d33259aefb8156f977f1df382
      https://github.com/llvm/llvm-project/commit/f669b9c3eca9438d33259aefb8156f977f1df382
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-05-31 (Sat, 31 May 2025)

  Changed paths:
    M lldb/unittests/Core/MangledTest.cpp

  Log Message:
  -----------
  [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer (#137793)

To test the infrastructure added in
https://github.com/llvm/llvm-project/pull/131836 in would be nice to
confirm that we can reconstruct all kinds of demangled names. The
libcxxabi test-suite already has all those test-cases.

This patch copies those test-cases (taken from
`libcxxabi/test/test_demangle.pass.cpp`), reconstructs the name like
LLDB would when showing backtraces, and confirms that all demangled
names can be fully reconstructed.

Two open questions:
1. Do we really want a copy of all those test-cases in LLDB? It's
unlikely to be kept in sync with the demangler test-suite. It includes
30,000+ test-cases
2. Do we want to turn the
`GetDemangledBasename`/`GetDemangledScope`/etc. into public APIs (e.g.,
on `TrackingOutputBuffer`) so that we can use the exact same method of
extraction in the tests?



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications