[all-commits] [llvm/llvm-project] 22dfe9: [lldb-dap] Reuse source object logics (#141426)

[Ely Ronnen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 22dfe9cb589308d94daa00ae533a16a24a012fd9
      https://github.com/llvm/llvm-project/commit/22dfe9cb589308d94daa00ae533a16a24a012fd9
  Author: Ely Ronnen <elyronnen at gmail.com>
  Date:   2025-05-31 (Sat, 31 May 2025)

  Changed paths:
    M lldb/source/API/SBTarget.cpp
    M lldb/source/Core/Module.cpp
    M lldb/tools/lldb-dap/Breakpoint.cpp
    M lldb/tools/lldb-dap/CMakeLists.txt
    M lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp
    M lldb/tools/lldb-dap/Handler/LocationsRequestHandler.cpp
    M lldb/tools/lldb-dap/Handler/StackTraceRequestHandler.cpp
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/JSONUtils.h
    M lldb/tools/lldb-dap/LLDBUtils.cpp
    M lldb/tools/lldb-dap/LLDBUtils.h
    A lldb/tools/lldb-dap/ProtocolUtils.cpp
    A lldb/tools/lldb-dap/ProtocolUtils.h

  Log Message:
  -----------
  [lldb-dap] Reuse source object logics (#141426)

Refactor code revolving source objects such that most logics will be
reused.

The main change is to expose a single `CreateSource(addr, target)` that
can return either a normal or an assembly source object, and call
`ShouldDisplayAssemblySource()` only from this function instead of
multiple places across the code.

Other functions can use `source.IsAssemblySource()` in order to check
which type the source is.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications