[all-commits] [llvm/llvm-project] 9e9626: [LLDB] Avoid crashes when inspecting MSVC STL type...

[nerix via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e9626b3d5aa56828b71b03d99bf3167fdfeb08d
      https://github.com/llvm/llvm-project/commit/9e9626b3d5aa56828b71b03d99bf3167fdfeb08d
  Author: nerix <nerixdev at outlook.de>
  Date:   2025-05-30 (Fri, 30 May 2025)

  Changed paths:
    M lldb/source/Plugins/Language/CPlusPlus/GenericOptional.cpp
    M lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp
    A lldb/test/Shell/Process/Windows/msstl_smoke.cpp

  Log Message:
  -----------
  [LLDB] Avoid crashes when inspecting MSVC STL types (#140761)

When inspecting/printing types from MSVC's STL, LLDB would crash because
it assumes these types were from libstdc++. Specifically,
`std::shared_ptr` and `std::optional` would crash because of a null
pointer dereference. I added a minimal test that tests the types with
C++ helpers for libstdc++ (only tests for crashes).

- Fixes #115216 
- Fixes #120310 

This still has one unresolved discussion: What about MS STL types? This
is https://github.com/llvm/llvm-project/issues/24834, but there was a
bit of discussion in #120310 as well. The main issue is that MSVC's STL
uses the same type names as libstdc++ (i.e. neither uses an inline
namespace like libc++ for some types).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications