[all-commits] [llvm/llvm-project] 7bd8e3: Reland "[lldb][Modules] Fix error handling of pars...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7bd8e376fca22cac9593e93450a545573d3ff5f4
      https://github.com/llvm/llvm-project/commit/7bd8e376fca22cac9593e93450a545573d3ff5f4
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2025-05-29 (Thu, 29 May 2025)

  Changed paths:
    M lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
    M lldb/test/API/lang/cpp/gmodules/template-with-same-arg/TestTemplateWithSameArg.py
    M lldb/test/API/lang/cpp/gmodules/template-with-same-arg/main.cpp

  Log Message:
  -----------
  Reland "[lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (#141220)"

This reverts commit 57f3151a3144259f4e830fc43a1424e4c1f15985.

LLDB was hitting an assert when compiling the `std` module. The `std`
module was being pulled in because we use `#import <cstdio>` in the test
to set a breakpoint on `puts`. That's redundant and to work around the
crash we just remove that include. The underlying issue of compiling the
`std` module still exists and I'll investigate that separately. The
reason it started failing after the `ClangModulesDeclVendor` patch is that we would previously just fail to load the modulemap (and thus not load any of the modules). Now we do load the modulemap (and modules) when we prepare for parsing the expression.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications