[all-commits] [llvm/llvm-project] 74a102: [libcxx] [test] Change an MSVC mode XFAIL into UNS...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue May 27 23:21:51 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74a102fc1cbcdc04d02b4edf9bbcbdc93124d5c1
      https://github.com/llvm/llvm-project/commit/74a102fc1cbcdc04d02b4edf9bbcbdc93124d5c1
  Author: Martin Storsjö <martin at martin.st>
  Date:   2025-05-28 (Wed, 28 May 2025)

  Changed paths:
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new.size_nothrow.replace.indirect.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Change an MSVC mode XFAIL into UNSUPPORTED (#141609)

The underlying bug in vcruntime [1] has been fixed in the latest version
of MSVC (released two weeks ago); this will cause the test which is
currently marked XFAIL to start erroring, when it starts passing
unexpectedly.

This version of MSVC may soon start appearing in the Github Actions
runner images used for our CI.

We could try to detect the state of this bug, but in practice, such
detection code would essentially be a copy of this whole test.

Therefore, just mark this test UNSUPPORTED for the MSVC mode builds. If
we at some point require new enough MSVC libraries, we could remove the
marking entirely.

[1]
https://developercommunity.visualstudio.com/t/vcruntime-nothrow-array-operator-new-fal/10373274



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list