[all-commits] [llvm/llvm-project] c1970c: [libcxxabi] Add test to assert that ItaniumDemangl...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c1970c76adf70ca8ade7ac5d3bb57872e2daf1fd
      https://github.com/llvm/llvm-project/commit/c1970c76adf70ca8ade7ac5d3bb57872e2daf1fd
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2025-05-27 (Tue, 27 May 2025)

  Changed paths:
    M libcxxabi/test/configs/cmake-bridge.cfg.in
    A libcxxabi/test/itanium_demangle_matches_llvm.sh.test

  Log Message:
  -----------
  [libcxxabi] Add test to assert that ItaniumDemangle.h is the same (#140323)

ItaniumDemangle.h exists in both llvm/ and libcxxabi/. These files are
supposed to be copies of each other (minus the top two lines). This
patch adds a test to assert that this is the case to enable tooling to
automatically detect this as an issue, like in #139825. This makes it
easier for contributors unfamiliar with the duplication to make
changes/get appropriate reviews.

Ideally we would share the file and copy it from one place to the other
but the ideal way to do this (based on previous discussion with libc++
maintainers) would be a new runtime library that clearly outlines
requirements, so that is left for later with the test being used as a
stopgap. This is a relatively common approach for structures shared
between compiler-rt and LLVM.

This patch does make the test reference the LLVM source directory, but
that should be fine given building libcxxabi is only supported through
the runtimes build in the monorepo meaning it should always be
available.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications