[all-commits] [llvm/llvm-project] 76ee2d: MCParser: Error when .set reassigns a non-redefina...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon May 26 20:20:15 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 76ee2d34f787357eec1a5dec16b294578151881e
      https://github.com/llvm/llvm-project/commit/76ee2d34f787357eec1a5dec16b294578151881e
  Author: Fangrui Song <i at maskray.me>
  Date:   2025-05-26 (Mon, 26 May 2025)

  Changed paths:
    M llvm/lib/MC/MCAsmStreamer.cpp
    M llvm/lib/MC/MCParser/AsmParser.cpp
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    A llvm/test/MC/AsmParser/redef-err.s
    A llvm/test/MC/AsmParser/redef.s
    R llvm/test/MC/AsmParser/variables-invalid.s
    M llvm/test/MC/ELF/weakref.s

  Log Message:
  -----------
  MCParser: Error when .set reassigns a non-redefinable variable

The conditions in parseAssignmentExpression are conservative. We should
also report an error when a non-redefiniable variable (e.g. .equiv
followed by .set; .weakref followed by .set).

Make MCAsmStreamer::emitLabel call setOffset to make the behavior
similar to MCObjectStreamer. `isUndefined()` can now be replaced with
`isUnset()`.

Additionally, fix an AMDGPU API user (tested by a few tests including
MC/AMDGPU/hsa-v4.s)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list