[all-commits] [llvm/llvm-project] d03f30: [mlir][TOSA] restore unrealized casts when lowerin...

[Artem Gindinson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d03f30fb522eda7dedd15fd83ba1077d14826e0f
      https://github.com/llvm/llvm-project/commit/d03f30fb522eda7dedd15fd83ba1077d14826e0f
  Author: Artem Gindinson <gindinson at roofline.ai>
  Date:   2025-05-26 (Mon, 26 May 2025)

  Changed paths:
    M mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
    M mlir/test/Conversion/TosaToLinalg/tosa-to-linalg.mlir

  Log Message:
  -----------
  [mlir][TOSA] restore unrealized casts when lowering rescale ops (#141096)

Along with the changes to rescale op attributes, commit 7208649 dropped
the builtin casts between signed and signless types. However, explicitly
unsigned types are still legal input and output values from the TOSA IR
perspective.

The change adds back the casts when the unsigned<->signless semantics
are explicit in the underlying tensor types. This prevents the
conversion routine from trying to generate illegal `arith` casts that
are constrained to signless types. Whether the `arith` casts themselves
are signed or unsigned should still depend on the rescale's `*_unsigned`
attribute values.

---------

Signed-off-by: Artem Gindinson <gindinson at roofline.ai>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications