[all-commits] [llvm/llvm-project] 695d72: [lldb-dap] Assorted small fixes for runInTerminal ...

Hu Jialun via All-commits all-commits at lists.llvm.org
Thu May 22 20:20:57 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 695d725edfb71e3e048229b96a5b3e9c2adad048
      https://github.com/llvm/llvm-project/commit/695d725edfb71e3e048229b96a5b3e9c2adad048
  Author: Hu Jialun <hujialun at outlook.sg>
  Date:   2025-05-22 (Thu, 22 May 2025)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/JSONUtils.h

  Log Message:
  -----------
  [lldb-dap] Assorted small fixes for runInTerminal (#140908)

- `CreateRunInTerminalReverseRequest` is passed a `StringMap` by value,
whose keys are owned and deallocated after return.
- Target args are wrongly specified as reverse request (launcher) args.
- Test case error message did not catch up with a0aa5f8.

All runInTerminal tests are passing with this applied.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list