[all-commits] [llvm/llvm-project] 6a8dde: [MLIR] Change getBackwardSlice to return a logical...

[William Moses via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6a8dde04a07287f837bbabeb93e23e47af366d3d
      https://github.com/llvm/llvm-project/commit/6a8dde04a07287f837bbabeb93e23e47af366d3d
  Author: William Moses <gh at wsmoses.com>
  Date:   2025-05-22 (Thu, 22 May 2025)

  Changed paths:
    M mlir/include/mlir/Analysis/SliceAnalysis.h
    M mlir/include/mlir/Query/Matcher/SliceMatchers.h
    M mlir/lib/Analysis/SliceAnalysis.cpp
    M mlir/lib/Conversion/VectorToGPU/VectorToGPU.cpp
    M mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp
    M mlir/lib/Dialect/NVGPU/TransformOps/NVGPUTransformOps.cpp
    M mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
    M mlir/lib/Transforms/Utils/RegionUtils.cpp
    M mlir/test/lib/Dialect/Affine/TestVectorizationUtils.cpp
    M mlir/test/lib/IR/TestSlicing.cpp

  Log Message:
  -----------
  [MLIR] Change getBackwardSlice to return a logicalresult rather than crash (#140961)

The current implementation of getBackwardSlice will crash if an
operation in the dependency chain is defined by an operation with
multiple regions or blocks. Crashing is bad (and forbids many analyses
from using getBackwardSlice, as well as causing existing users of
getBackwardSlice to fail for IR with this property).

This PR instead causes the analysis to return a failure, rather than
crash in the cases it cannot compute the full slice

---------

Co-authored-by: Oleksandr "Alex" Zinenko <git at ozinenko.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications