[all-commits] [llvm/llvm-project] 8d0a48: [XRay] Fix argument parsing with offloading (#1407...

Sebastian Kreutzer via All-commits all-commits at lists.llvm.org
Thu May 22 07:06:45 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d0a484983ef3e35e46d7979d749c96203b0296b
      https://github.com/llvm/llvm-project/commit/8d0a484983ef3e35e46d7979d749c96203b0296b
  Author: Sebastian Kreutzer <SebastianKreutzer at gmx.net>
  Date:   2025-05-22 (Thu, 22 May 2025)

  Changed paths:
    M clang/include/clang/Driver/ToolChain.h
    M clang/lib/Driver/ToolChain.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/Driver/XRay/xray-instrument.c

  Log Message:
  -----------
  [XRay] Fix argument parsing with offloading (#140748) (#141043)

This PR addressed issue #140748 to support XRay instrumentation on the
host side when using offloading.

It makes the following changes:
- Initializes `XRayArgs` using the processed toolchain arguments instead
of the raw input.
- Removes the current caching mechanism of `XRayArgs` in the `ToolChain`
class, as this is error-prone and potential benefits are questionable.
For reference, `SanitizierArgs`, which is constructed in a similar
manner but is much more complex, does not use any caching.
- Adds driver tests to verify that XRay flags are set correctly with
offloading and `-Xarch_host`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list