[all-commits] [llvm/llvm-project] 898df4: [flang] Skip opt-bufferization when memory effect ...

[Asher Mancinelli via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 898df4b8ed86f6590e8496c2108c1611dca710ab
      https://github.com/llvm/llvm-project/commit/898df4b8ed86f6590e8496c2108c1611dca710ab
  Author: Asher Mancinelli <ashermancinelli at gmail.com>
  Date:   2025-05-22 (Thu, 22 May 2025)

  Changed paths:
    M flang/lib/Optimizer/HLFIR/Transforms/OptimizedBufferization.cpp
    A flang/test/HLFIR/opt-bufferization-skip-volatile.fir

  Log Message:
  -----------
  [flang] Skip opt-bufferization when memory effect does not have an associated value (#140781)

Memory effects on the volatile memory resource may not be attached to a
particular source, in which case the value of an effect will be null.
This caused this test case to crash in the optimized bufferization
pass's safety analysis because it assumes it can get the SSA value
modified by the memory effect. This is because memory effects on the
volatile resource indicate that the operation must not be reordered with
respect to other volatile operations, but there is not a material ssa
value that can be pointed to.

This patch changes the safety checks such that memory effects which do
not have associated values are not safe for optimized bufferization.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications