[all-commits] [llvm/llvm-project] 2d956d: [flang] fix ICE with ignore_tkr(tk) character in e...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d956d2d4ecd6191cd0eab76ec705f5ea2916d59
      https://github.com/llvm/llvm-project/commit/2d956d2d4ecd6191cd0eab76ec705f5ea2916d59
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2025-05-21 (Wed, 21 May 2025)

  Changed paths:
    M flang/lib/Lower/ConvertCall.cpp
    M flang/test/Lower/HLFIR/ignore-type-f77-character.f90

  Log Message:
  -----------
  [flang] fix ICE with ignore_tkr(tk) character in explicit interface (#140885)

Some MPI libraries use character dummies + ignore(TKR) to allow passing
any kind of buffer.

This was meant to already be handled by #108168
However, when the library interface also had an argument requiring an
explicit interface, `builder.convertWithSemantics` was not allowed to properly deal
with the actual/dummy type mismatch and generated bad IR causing errors like:
`'fir.convert' op invalid type conversion'!fir.ref' / '!fir.boxchar\<1\>'`.

This restriction was artificial, lowering should just handle any cases
allowed by semantics. Just remove it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications