[all-commits] [llvm/llvm-project] 9d0614: [lldb-dap] fix disassembly request instruction off...

[Ely Ronnen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d0614e77ab1c5e2264e07d9b4b5f9780b38781c
      https://github.com/llvm/llvm-project/commit/9d0614e77ab1c5e2264e07d9b4b5f9780b38781c
  Author: Ely Ronnen <elyronnen at gmail.com>
  Date:   2025-05-21 (Wed, 21 May 2025)

  Changed paths:
    M lldb/include/lldb/API/SBTarget.h
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py
    M lldb/source/API/SBTarget.cpp
    M lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py
    M lldb/test/API/tools/lldb-dap/disassemble/main.c
    M lldb/test/API/tools/lldb-dap/instruction-breakpoint/TestDAP_instruction_breakpoint.py
    M lldb/tools/lldb-dap/Handler/DisassembleRequestHandler.cpp

  Log Message:
  -----------
  [lldb-dap] fix disassembly request instruction offset handling (#140486)

Fix the handling of the `instructionOffset` parameter, which resulted in
always returning the wrong disassembly because VSCode always uses
`instructionOffset = -50` and expects 50 instructions before the given
address, instead of 50 bytes before



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications