[all-commits] [llvm/llvm-project] 6cac79: [mlir][Vector] Improve `vector.mask` verifier (#13...

[Diego Caballero via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6cac792bf9eacb1ed0c80fc7c767fc99c50e2524
      https://github.com/llvm/llvm-project/commit/6cac792bf9eacb1ed0c80fc7c767fc99c50e2524
  Author: Diego Caballero <dieg0ca6aller0 at gmail.com>
  Date:   2025-05-20 (Tue, 20 May 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/Vector/IR/VectorOps.td
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/Vector/invalid.mlir

  Log Message:
  -----------
  [mlir][Vector] Improve `vector.mask` verifier (#139823)

This PR improves the `vector.mask` verifier to make sure it's not
applying masking semantics to operations defined outside of the
`vector.mask` region. Documentation is updated to emphasize that and
make it clearer, even though it already stated that.

As part of this change, the logic that ensures that a terminator is
present in the region mask has been simplified to make it less
surprising to the user when a `vector.yield` is explicitly provided in
the IR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications