[all-commits] [llvm/llvm-project] f171e0: [NFC][OpenACC] Refactor clause emission- (#140586)

Erich Keane via All-commits all-commits at lists.llvm.org
Mon May 19 15:47:47 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f171e050411efbed46c483db6d4dff7814e2d3e4
      https://github.com/llvm/llvm-project/commit/f171e050411efbed46c483db6d4dff7814e2d3e4
  Author: Erich Keane <ekeane at nvidia.com>
  Date:   2025-05-19 (Mon, 19 May 2025)

  Changed paths:
    M clang/lib/CIR/CodeGen/CIRGenFunction.h
    A clang/lib/CIR/CodeGen/CIRGenOpenACCClause.cpp
    R clang/lib/CIR/CodeGen/CIRGenOpenACCClause.h
    M clang/lib/CIR/CodeGen/CIRGenStmtOpenACC.cpp
    M clang/lib/CIR/CodeGen/CIRGenStmtOpenACCLoop.cpp
    M clang/lib/CIR/CodeGen/CMakeLists.txt

  Log Message:
  -----------
  [NFC][OpenACC] Refactor clause emission- (#140586)

Having the whole clause emission be in a header file ended up being
pragmatic, but ended up being a sizable negative for a variety of
reasons. This patch moves it to its own .cpp file and makes
CIRGenFunction instead call into the visitor via a template instead.

This is possible because the valid list of construct kinds is quite
finite, and easy to enumerate.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list