[all-commits] [llvm/llvm-project] f27cfe: [LLDB][Progress-On-Dap] Have indeterminate progres...
Jacob Lalonde via All-commits
all-commits at lists.llvm.org
Mon May 19 15:20:17 PDT 2025
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: f27cfeae6a544775803a50b3ed4c87e9193889a2
https://github.com/llvm/llvm-project/commit/f27cfeae6a544775803a50b3ed4c87e9193889a2
Author: Jacob Lalonde <jalalonde at fb.com>
Date: 2025-05-19 (Mon, 19 May 2025)
Changed paths:
M lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py
M lldb/tools/lldb-dap/ProgressEvent.cpp
Log Message:
-----------
[LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (#140162)
Recently, I got a report how a user 'hung', and come to find out it's
actually because DAP is checking percentage, and on non-deterministic
events, we will effectively never send a progress event to DAP. Here we
short circuit and don't view percentages for DAP messages and solely
depend on the DAP 250ms throttle, which is probably still too
aggressive, but better than no updates.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list