[all-commits] [llvm/llvm-project] 553d4c: [llvm] annotate interfaces in llvm/ADT for DLL exp...

[Andrew Rogers via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 553d4c1d90d9181b647b2028a90f59cdd8ebcb0b
      https://github.com/llvm/llvm-project/commit/553d4c1d90d9181b647b2028a90f59cdd8ebcb0b
  Author: Andrew Rogers <andrurogerz at gmail.com>
  Date:   2025-05-19 (Mon, 19 May 2025)

  Changed paths:
    M llvm/include/llvm/ADT/APFixedPoint.h
    M llvm/include/llvm/ADT/APFloat.h
    M llvm/include/llvm/ADT/APInt.h
    M llvm/include/llvm/ADT/APSInt.h
    M llvm/include/llvm/ADT/DAGDeltaAlgorithm.h
    M llvm/include/llvm/ADT/DeltaAlgorithm.h
    M llvm/include/llvm/ADT/DeltaTree.h
    M llvm/include/llvm/ADT/DynamicAPInt.h
    M llvm/include/llvm/ADT/FloatingPointMode.h
    M llvm/include/llvm/ADT/FoldingSet.h
    M llvm/include/llvm/ADT/IntEqClasses.h
    M llvm/include/llvm/ADT/IntervalMap.h
    M llvm/include/llvm/ADT/RewriteBuffer.h
    M llvm/include/llvm/ADT/RewriteRope.h
    M llvm/include/llvm/ADT/SlowDynamicAPInt.h
    M llvm/include/llvm/ADT/SmallPtrSet.h
    M llvm/include/llvm/ADT/SmallVector.h
    M llvm/include/llvm/ADT/Statistic.h
    M llvm/include/llvm/ADT/StringExtras.h
    M llvm/include/llvm/ADT/StringMap.h
    M llvm/include/llvm/ADT/StringRef.h
    M llvm/include/llvm/ADT/TrieRawHashMap.h
    M llvm/include/llvm/ADT/Twine.h

  Log Message:
  -----------
  [llvm] annotate interfaces in llvm/ADT for DLL export (#136629)

## Purpose

This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/ADT` library. These
annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.

## Background

This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).

The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.

The following manual adjustments were also applied after running IDS:

- Add `#include "llvm/Support/Compiler.h"` to files where it was not
auto-added by IDS due to no pre-existing block of include statements.
- Add `LLVM_ABI_FRIEND` to a small number of `friend` function
declarations
- Add `LLVM_ABI` to a subset of private class methods and fields that
require export

## Validation

Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:

- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications