[all-commits] [llvm/llvm-project] f7ef8d: [CIR] Fix problem with phantom function arguments ...

[Andy Kaylor via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f7ef8dcbad9d5ac6cf2a8917d5ce03564fdfd0d8
      https://github.com/llvm/llvm-project/commit/f7ef8dcbad9d5ac6cf2a8917d5ce03564fdfd0d8
  Author: Andy Kaylor <akaylor at nvidia.com>
  Date:   2025-05-16 (Fri, 16 May 2025)

  Changed paths:
    M clang/lib/CIR/CodeGen/CIRGenFunctionInfo.h

  Log Message:
  -----------
  [CIR] Fix problem with phantom function arguments (#140322)

There was a problem introduced today where sometimes the CIR for
functions with no arguments would be generated with phantom arguments.
This was causing intermittent test failures.

The problem appears to have been that we were using two different
Profile implementations to generate the FoldingSetNodeID for
CIRGenFunctionInfo so occaissionally when we tried to look for a
pre-existing entry for a function with no arguments it would incorrectly
match a CIRGenFunctionInfo entry that had arguments.

To prevent this from happening again, I rewrote one of the two Profile
functions to call the other.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications