[all-commits] [llvm/llvm-project] 33684a: [llvm][CFI] Do not canonicalize COFF functions in ...

[PiJoules via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 33684ac9be4892579f63a8e2b67080419426cf98
      https://github.com/llvm/llvm-project/commit/33684ac9be4892579f63a8e2b67080419426cf98
  Author: PiJoules <6019989+PiJoules at users.noreply.github.com>
  Date:   2025-05-16 (Fri, 16 May 2025)

  Changed paths:
    M llvm/lib/Transforms/IPO/LowerTypeTests.cpp
    A llvm/test/Transforms/LowerTypeTests/cfi-coff-comdat-rename.ll

  Log Message:
  -----------
  [llvm][CFI] Do not canonicalize COFF functions in a comdat (#139962)

COFF requires that a function exists with the same name as a comdat. Not
having this key function results in `LLVM ERROR: Associative COMDAT
symbol '...' does not exist.` CFI by default will attempt to
canonicalize a function by appending `.cfi` to its name which allows
external references to refer to the new canonical alias, but it does not
change the comdat name. We can change the comdat name since symbol and
comdat resolution occurs before LTO, so we already know which symbols
are prevailing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications