[all-commits] [llvm/llvm-project] 61c1f6: [cmake] Warn if LLVM_PROFDATA_FILE was specified b...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed May 14 12:05:20 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61c1f6d7e84f1213bd727437a7ec5b7fc5eaf121
      https://github.com/llvm/llvm-project/commit/61c1f6d7e84f1213bd727437a7ec5b7fc5eaf121
  Author: Martin Storsjö <martin at martin.st>
  Date:   2025-05-14 (Wed, 14 May 2025)

  Changed paths:
    M llvm/cmake/modules/HandleLLVMOptions.cmake

  Log Message:
  -----------
  [cmake] Warn if LLVM_PROFDATA_FILE was specified but wasn't found (#139882)

Ideally we should perhaps even error out here; if the user requested
building with profiling info, but that profile wasn't found, it seems
like the build configuration is subtly broken, and I would expect the
user to want to know about it. But that may be a too disruptive change,
as users may very well rely on being able to build things in such a
setup anyway thanks to Hyrum's Law.

To make things clearer, at least print a warning in this case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list